I can't see syntax errors. I would use lower-case letters for symbols, so that I am sure they don't conflict with built-in functions. You have an opportunity to use NestList:
loanBalanceCalculation2[principal_, yearlyRate_, payment_, months_] :=
NestList[# + yearlyRate/(12*100) # - payment &, principal, months]